Skip to content

fix(e2ee): counter update#17168

Open
alperozturk96 wants to merge 1 commit into
masterfrom
fix/e2ee-counter
Open

fix(e2ee): counter update#17168
alperozturk96 wants to merge 1 commit into
masterfrom
fix/e2ee-counter

Conversation

@alperozturk96

@alperozturk96 alperozturk96 commented Jun 11, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

alperozturk96
alperozturk96 commented Jun 11, 2026
View reviewed changes
Comment thread app/src/main/java/com/owncloud/android/operations/UploadFileOperation.java

private long getE2ECounter(OCFile parentFile) {
long counter = -1;
private long getE2ECounter(OCFile parentFile, Object metadata, boolean isEndToEndVersionAtLeastV2) {

@alperozturk96 alperozturk96 Jun 11, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already fetching metadata it was not used for counter.

@alperozturk96 alperozturk96 added this to the Nextcloud App 34.0.1 milestone Jun 11, 2026
@alperozturk96

alperozturk96 commented Jun 11, 2026

Copy link
Copy Markdown
Collaborator Author

/backport to stable-34.0.x

@github-actions

github-actions Bot commented Jun 11, 2026

Copy link
Copy Markdown

APK file: https://github.com/nextcloud/android/actions/runs/27335270281/artifacts/7562320224
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@alperozturk96
fix(e2ee): counter update
0a20589 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@github-actions

github-actions Bot commented Jun 15, 2026

Copy link
Copy Markdown

Codacy

SpotBugs

CategoryBaseNew
Bad practice3333
Correctness6767
Dodgy code215215
Experimental11
Internationalization77
Malicious code vulnerability22
Multithreaded correctness3131
Performance4141
Security1616
Total413413

@github-actions

github-actions Bot commented Jun 15, 2026

Copy link
Copy Markdown

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

@github-actions

github-actions Bot commented Jun 15, 2026

Copy link
Copy Markdown

APK file: https://github.com/nextcloud/android/actions/runs/27539710064/artifacts/7635526320
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tobiasKaminsky tobiasKaminsky Awaiting requested review from tobiasKaminsky

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

3. to review backport-request

Projects

None yet

Milestone

Nextcloud App 34.0.1

Development

Successfully merging this pull request may close these issues.

1 participant

@alperozturk96